Grow your CSS skills. Land your dream job.

Please Analyse my HTML Code And Give Feedback

  • # February 20, 2013 at 8:50 pm

    So how does my code stand? are there any unusual or unrecommended methods or errors? please let me know.[http://codepen.io/Jarolin/pen/aEyjb](http://codepen.io/Jarolin/pen/bsJxi “”)

    PS. It looks better than that. Just couldn’t link some images.

    # February 20, 2013 at 10:00 pm

    This should get you going in the right direction (note that I’ve quickly coded CSS just to get a feel for the page)

    http://codepen.io/anon/pen/xIAgL

    In your original code, you have numerous syntax errors. Run your code trough HTML validator. Also, you can not use same ID more than once on the page. Ex. id=”fnav”

    # February 20, 2013 at 10:56 pm

    Agree with @AlenAbdula, you can’t use same ID more than once.

    id=”fnav”

    # February 20, 2013 at 11:08 pm

    huh. I actually got rid of that a few days ago and is not on the original HTML code. But thanks anyway.

    # February 21, 2013 at 6:35 am

    Your input elements are badly formed

    Daily

    should be

    They also don’t have labels.

    # February 21, 2013 at 6:36 am

    >I actually got rid of that a few days ago and is not on the original HTML code

    Are you going to provide a new Codepen…or can this be marked **[Solved]**?

    # February 21, 2013 at 11:41 am

    A few notes:
    * As Paulie said, you need to connect **a label to each input**. This is accessibility 101.
    * You really should **use lists** when you are dealing with lists. It is the point.
    * **Don’t use <br>** when you can use padding/margin. It is not the point of a <br> tag.
    * You should use **reusable class names**. “one”, “two”, “three” are not great but I’m nitpicking.
    * Please **add alt="" tags to your images**. Once again, accessibility 101.
    * There are a couple of **missing attributes** (form misses action=""; button misses type="submit").
    * I don’t want to feed the troll but you should **use classes instead of ID**.
    * As far as I know, you shouldn’t use nav for the footer navigation. **nav aims at targeting the main navigation**.

Viewing 7 posts - 1 through 7 (of 7 total)

You must be logged in to reply to this topic.

*May or may not contain any actual "CSS" or "Tricks".