Forums

The forums ran from 2008-2020 and are now closed and viewable here as an archive.

Home Forums CSS Please Analyse my HTML Code And Give Feedback

  • This topic is empty.
Viewing 7 posts - 1 through 7 (of 7 total)
  • Author
    Posts
  • #42885
    Anonymous
    Inactive

    So how does my code stand? are there any unusual or unrecommended methods or errors? please let me know.[http://codepen.io/Jarolin/pen/aEyjb](http://codepen.io/Jarolin/pen/bsJxi “”)

    PS. It looks better than that. Just couldn’t link some images.

    #125469
    Alen
    Participant

    This should get you going in the right direction (note that I’ve quickly coded CSS just to get a feel for the page)

    http://codepen.io/anon/pen/xIAgL

    In your original code, you have numerous syntax errors. Run your code trough HTML validator. Also, you can not use same ID more than once on the page. Ex. id=”fnav”

    #125472
    Chester
    Participant

    Agree with @AlenAbdula, you can’t use same ID more than once.

    id=”fnav”

    #125473
    Anonymous
    Inactive

    huh. I actually got rid of that a few days ago and is not on the original HTML code. But thanks anyway.

    #125506
    Paulie_D
    Member

    Your input elements are badly formed

    Daily

    should be

    They also don’t have labels.

    #125507
    Paulie_D
    Member

    >I actually got rid of that a few days ago and is not on the original HTML code

    Are you going to provide a new Codepen…or can this be marked **[Solved]**?

    #125558
    Kitty Giraudel
    Participant

    A few notes:
    * As Paulie said, you need to connect **a label to each input**. This is accessibility 101.
    * You really should **use lists** when you are dealing with lists. It is the point.
    * **Don’t use <br>** when you can use padding/margin. It is not the point of a <br> tag.
    * You should use **reusable class names**. “one”, “two”, “three” are not great but I’m nitpicking.
    * Please **add alt="" tags to your images**. Once again, accessibility 101.
    * There are a couple of **missing attributes** (form misses action=""; button misses type="submit").
    * I don’t want to feed the troll but you should **use classes instead of ID**.
    * As far as I know, you shouldn’t use nav for the footer navigation. **nav aims at targeting the main navigation**.

Viewing 7 posts - 1 through 7 (of 7 total)
  • The forum ‘CSS’ is closed to new topics and replies.