Grow your CSS skills. Land your dream job.

My first HTML&CSS try – want review

  • # February 9, 2014 at 2:31 pm

    this is my first try to do some thing using what i learn in HTML&CSS

    it is like Facebook cover & profile picture part

    so please review my code

    i hope you give your comments & suggestions to improve my self

    this is my code

    https://gist.github.com/HeshamGhoniem/b324b4323516afbd1392

    and this is a preview of what i do http://codepen.io/HeshamGhoniem/full/rbvAK

    # February 10, 2014 at 10:55 am

    Looking good, Hesham :)

    Personally I’d style the button text like below, so no need for <span> tags inside the button’s markup.

    button {
      font-weight: bold;
    }
    

    Of course, this way means all buttons will be bold by default but for the code you posted for “review” it’s what I’d do.

    # February 10, 2014 at 11:18 am

    you are right

    Thanks very much for your comment

    # February 10, 2014 at 12:39 pm

    That’s o.k, but please don’t see it as me being right because how you’ve coded it isn’t wrong. Even a simple thing like styling a button’s text can be done lots of ways.

    I hope you’re having fun. I’m learning, too. It never stops.

    # February 10, 2014 at 1:06 pm

    :) :) :)

    i say you are right about that i should not use any tag or code that i can achieve my purpose without it

    i know that you are speaking about best practice

    that’s all

    :) :) :)

    # February 10, 2014 at 1:19 pm

    Cool, smiles all ’round.

    A heads up in case you didn’t know: codepen doesn’t need <html>, <head> and <body> tags but if you’re getting in the habit of typing them then more power to you and ignore me.

    dnp
    # February 11, 2014 at 1:37 am

    Nice psd to html conversion

    # February 12, 2014 at 4:51 am

    The link is not loading

    # February 14, 2014 at 4:17 pm

    krbabu.web33

    all links loading correctly for me

    Soren
    i copied code form editor to codepen :)

    —————————————————–=
    dnp
    Thanks

Viewing 9 posts - 1 through 9 (of 9 total)

You must be logged in to reply to this topic.

*May or may not contain any actual "CSS" or "Tricks".