this is my first try to do some thing using what i learn in HTML&CSS
it is like Facebook cover & profile picture part
so please review my code
i hope you give your comments & suggestions to improve my self
this is my code
and this is a preview of what i do http://codepen.io/HeshamGhoniem/full/rbvAK
Looking good, Hesham :)
Personally I’d style the button text like below, so no need for <span> tags inside the button’s markup.
Of course, this way means all buttons will be bold by default but for the code you posted for “review” it’s what I’d do.
you are right
Thanks very much for your comment
That’s o.k, but please don’t see it as me being right because how you’ve coded it isn’t wrong. Even a simple thing like styling a button’s text can be done lots of ways.
I hope you’re having fun. I’m learning, too. It never stops.
:) :) :)
i say you are right about that i should not use any tag or code that i can achieve my purpose without it
i know that you are speaking about best practice
Cool, smiles all ’round.
A heads up in case you didn’t know: codepen doesn’t need <html>, <head> and <body> tags but if you’re getting in the habit of typing them then more power to you and ignore me.
Nice psd to html conversion
The link is not loading
all links loading correctly for me
i copied code form editor to codepen :)
You must be logged in to reply to this topic.