Re: My first crack at a wordpress theme

[Rob MacKay]

Well done! Its tidy, which is excellent!

Graphically, I would save your head-line.jpg as an 8bit transparent PNG, then you wouldn’t have the background lining up issues. The background itself I feel is a little overwhelming…

Code wise, its pretty solid, if a little untidy :) Here are some extra pointers…

Your nav ul is wrapped in a navbar div, you don’t need to wrap your UL in a DIV for that, because the UL will do exactly the same thing as the div. They are both block elements and can be styled the same way – so your DIV is a little redundant.

Add

ul#nav li a {
outline:none;
}

to your CSS to get rid of the strange dotted outline when your link is active, coz you are using text-indent, it stretches off the page.

you head elements are obviously using padding and margin for positioning… use "position" its much better.

and one last small thing, your page wrap doesn’t wrap around your page, this can cause some issues else where… add:

overflow:hidden;
height:auto;

to your wrap div style, and it will stretch out nicely.

Other than that well done! Its a hard job doing your first theme, congratulations!