Please critique my technique

[JoshWhiteDesign]

Hi, I’m pretty new to jQuery as a whole and really have appreciated the help and feedback of these forums. I just was hoping someone could tell me if this is the best way to do this. I finally got this thing working (haven’t added all the sweet stuff to it).

http://www.citrusbunny.com/
*It’s the "Contact Us" on the right side – supposed to slide out*

through my research it seems there are a ton of different ways to get jQuery to do what you want. Was this the best way to execute this? Should I have done it differently?

I just want to make sure I’m doing it right rather than "just making it work".

This is the code for the slide:

stylesheet.css

Code:

li.action {
font-family: georgia;
font-size: 20px;
color: #777;
margin-left:15px;
}
li.action:hover {
color: #000;
}
#contactslide {
height: 200px;
width: 250px;
background-color:#ffffff;
margin-left: 40px;
padding:0px;
margin-top:0px;
margin-bottom:0px;
}

indexcustom.php

Code:

• Contact Us

520-555-5555

Header.php

Code:

[tomwalters5678]

Nope – that looks just fine! The only important thing is that it makes sense to you and anyone else that will be coding on the site.

[Mr KiTT3N]

Few things to note, avoid using inline styling

Code:

For questions of any kind, please call us Monday – Friday 8am to 5pm. Otherwise email us and we will contact you in 2 shakes of a lambs tail.

520-205-2306

Code:

For questions of any kind, please call us Monday – Friday 8am to 5pm. Otherwise email us and we will contact you in 2 shakes of a lambs tail.

520-205-2306

// css file
div#contactslide p { text-align: center; }
div#contactslide p.contactNumber { font-family: georgia; color: rgb(119, 119, 119); font-weight: bold; font-size: 30px;}

Its bad practice and clean code is just better for the eyes ;)

2nd thing

In css its encouraged to use as many elements to select one (I.E. == html body div.content div#nav li.action {….)
When using jquery, its just the opposite

Code:

jQuery(“li.action”).click(function(){….

What this is doing is selecting every single <li> on the page…. stores them and then filters all those <li> looking for the class name "action"

note: Selecting by a class is slower than id

3rd thing

Code:

[Author]

Posts