- This topic is empty.
September 22, 2008 at 10:56 am #23300
I need some feedback and opinions about the design / code of this website:
What you think?
Thank you. :DSeptember 22, 2008 at 3:39 pm #49957curtismchaleMember
I like the design. Clean and nice colours.
Is there a reason that you need a <div> to wrap the images that just applies a class to them? You can add a second class to the image just by using a space between the classes. When I code a site I always like to add an HTML comment that names the end of each div so I know which div ends where.
It can also be more appropriate to use the <strong> instead of <b> tag if you acutally want the item to have emphasis. If it is strictly a visual enhancement I use <b> but some will disagree.
I notice that there is no conditional stylesheet for IE. Just wonder if you made sure the site works properly in IE 6 & 7 you may not need it but I find that normally you do.September 23, 2008 at 11:57 am #49984cssgirlParticipant
Very nice, very clean. Love the blue shades. I agree about the div class surrounding the images. I don’t see any imageElement class in your main stylesheet either. Maybe leftover?
Also, looks sweet in all browsers, IE6/7 and FF3 on PC. :)
Conditional stylesheets are not always needed so that doesn’t mean it’s not cross browser compatible. I’m always so happy when I code a new template and it works right off the bat with no conditionals need. Makes me do my little cross-browser-happy-dance. ;)September 24, 2008 at 9:09 am #50001
Thanks for your feedback.
Yes i aways make sure that the website works in all browsers. Normally i dont create a different css file to fix bugs on IE, should i separete the files? And i will start using <strong> instead of <b>.
Sorry for my english, i hope you understand me :DSeptember 24, 2008 at 5:21 pm #50009
btw, i’m having a problem with the space between h1.newsletter and the next <p> in IE6 and 7.
[img]http://img4.uploadhouse.com/fileuploads/2688/26885245f83612f20995f9245844aeb74eac9cf.jpg[/img]September 24, 2008 at 11:44 pm #50030cssgirlParticipant
Looks like your margin is being doubled. I’d create a seperate IE style using conditionals, and cutting the margin for that p within that div in half and see if it fixes the issue.
- The forum ‘Other’ is closed to new topics and replies.