Error with Popup function

[Chris Lowles]

I am testing out a popup function and its not working, heres my sample.

`
/* Popup Plugin */
function popup(url, w, h) {
var left = (screen.width / 2) – (w / 2);
var top = (screen.height / 2) – (h / 2);
var targetWin = window.open(url, “_popup”, “width=” + w + “, height=” + h + “, top=” + top + “, left=” + left);
}

$(“.tw-share”).click(function() {
popup(“//gadsbysociao.tumblr.com/make#textnet-twshare”, “400”, “250”);
});

$(“.fb-share”).click(function() {
popup(“//gadsbysociao.tumblr.com/make#textnet-fbshare”, “400”, “250”);
});
`

I need some help so bad.

[chrisburton]

Please add your code to CodePen.

[Chris Lowles]

Sorry, will do.

Ok here it is: Link

[chrisburton]

What about your HTML?

[Chris Lowles]

K just fixed it.

[TheDoc]

You’re not using the proper n-dash (-) for the subtraction. Looks like the m-dash (–) is causing the ILLEGAL token error.

[chrisburton]

There’s also a mix of straight and curly quotes.

[Chris Lowles]

i don’t seem to have the m-dash as a key on my keyboard

[TheDoc]

Looks like it’s working now? It’s not working on Codepen because:

Blocked opening 'http://gadsbysociao.tumblr.com/make#textnet-twshare' in a new window because the request was made in a sandboxed frame whose 'allow-popups' permission is not set.

[Chris Lowles]

How do I set the allow-frames permission?

[James]

You can’t, as CodePen previews are displayed within an iframe and the sandbox mode for the preview simply won’t allow popups.

[Author]

Posts