- This topic is empty.
Viewing 4 posts - 1 through 4 (of 4 total)
Viewing 4 posts - 1 through 4 (of 4 total)
- The forum ‘CSS’ is closed to new topics and replies.
The forums ran from 2008-2020 and are now closed and viewable here as an archive.
I was wondering if someone might look at my code and critique it (or point me in a direction where it can be). I have most of the site laid out as it is in the design, but I am not sure I have done it in the most efficient or correct way.
I am also having issues with my footer and need some help with it.
Thanks
My html and css: http://nyk-london.com/
A preview of the psd template file: http://nyk-london.com/preview.JPG
I am working with safari and firefox, not to worried about IE yet as i just want to get it working.
Thanks for any help
the biggest thing i would say is use some more short hand in your css. for example instead of:
border-bottom: #ffffff 1px
border-bottom: dotted;
use
border-bottom: 1px #ffffff dotted;
the same can be done for backgrounds
background-image: url(image location) repeat type background position;
Certainly is a beautiful template to learn coding from. I love Brandon’s work.
I don’t have time to go through it all at the moment, but you can start with correcting some of these 108 errors!
lol yeah, loads of errors.
Thanks a lot for taking the time to look at it. I have taken it down now to work on it a little more