A Web Page Review
# June 23, 2013 at 5:42 pm
Still unneeded divs in there. Instead of having a `` you can just add the `.navigation` class to the `
- ` itself. You shouldn’t be including a clearing div when you can just add a class of `.clearfix` to your wrapper and add the appropriate CSS. You don’t need a div around your logo, simply apply the `.logo` class to the `` itself.
I could go on and on with these examples, hopefully you see what I’m getting at!# June 23, 2013 at 6:54 pm
This reply has been reported for inappropriate content.
I’ll be honest and admit that I have that problem too. I too do want to learn all of the things. but I believe that I am moving too fast and should continue working on small stuff. thanks for the insight and your honesty. it’s not easy admitting it. but i too need to focus more! and @CodeGraphics i love your work with noise backgrounds ! adds that extra flair. visually appealing but i too have noticed a few of your layouts do repeat the grid for things being in 3 columns. try breaking that up. but appropriately. keep up the good work my man!
and about the whole class of logo in the a. there’s things like that that I too don’t think about.# June 23, 2013 at 9:28 pm
> I really need to learn how to write well structured, semantic and clean html/css.
Wrapping elements with `div` is not semantically wrong. Divs are used to logically group elements. It might be messy or unnecessary. but certainly not wrong.
As for the design, it’s not done so it’s pointless to give feedback… I think if you ask for feedback about specific feature that you need help with, then we can give you some constructive criticism that actually helps. LIke this you’ll get random thoughts that you can’t really act upon.
You must be logged in to reply to this topic.