The forums ran from 2008-2020 and are now closed and viewable here as an archive.

Home Forums Design Some feed back on my mark-up. Reply To: Some feed back on my mark-up.



You’re definitely on the right track, just needs tightening up (aka: practice, practice, practice) :)

As far as general nit-picks, I wouldn’t recommend having text (the spans in your case) colors/styles so similar to links as it is confusing.

Also, for a “cover” image in the background up the top, needs to be far higher resolution.

Now for the code: here is how I re-factored it quickly for you to take a look at, this isn’t exactly how I would personally code it from scratch but it’s a step in that direction.