I think I am almost done with my first design portfolio. I don’t have too much under my belt right now, and would love some tips, and generally some critiques.
It would help me so much. And please be brutally honest, how else will I learn, amirite?
I think the biggest thing I’m going to say is that the design is overall decent (I would avoid leaving the body font up to whatever the default is on their system), but the code is atrocious.
- bgcolor on the body (use CSS)
- tables for positioning (use CSS)
- More padding on description (let the text breaaaaathe! =)
- IDs are supposed to be unique (see your tables)
- Inline width/height/etc on the tables (use CSS)
- Old markup, even if you’re not using HTML5 elements (there’s some you could replace with HTML5 elements, but that’s not necessary), I’d replace the doctype declaration with `< !DOCTYPE html>` and the HTML declaration with ``
- Perhaps add `` to the head as well, to set the charset
The site design is, as noted above, reasonably attractive and I think visually pretty clean – much better than a lot of sites. (However the backgrounds – header area and body – aren’t doing you any favors.)
I strongly agree with the suggestions to get rid of the tables and to start using HTML5.
But the first thing I’d address is correcting the substantial number of validation errors (mostly HTML, a few CSS).
Also, consider making the design flexible or better yet responsive – IMO the days of fixed-width designs have passed, and if this is to be a portfolio site touting your mastery of the latest best practices, RWD should be near the top of your list.
You could make navigation a bit more attractive. Using another color than black would be a good start (especially when dealing with a dark grey background).
As Melindrea says, try improving the font. Pick a sans-serif font you like (Helvetica Neue, Source Code, Open sans, etc.) and use it for all text content across your site (except maybe headings). Also, choose a much much bigger font size.
Viewing 5 posts - 1 through 5 (of 5 total)
You must be logged in to reply to this topic.
*May or may not contain any actual "CSS" or "Tricks".