Forums

The forums ran from 2008-2020 and are now closed and viewable here as an archive.

Home › Forums › CSS › Class assignment critique?

  • This topic is empty.
Viewing 3 posts - 1 through 3 (of 3 total)
  • Author
    Posts
  • May 21, 2013 at 3:12 pm #44944
    Attila Hajzer
    Participant

    http://jsfiddle.net/attilahajzer/mgmdp/1/embedded/result/

    check out the code for fonts and all. here’s a screenshot too:

    https://twitpic.com/cs8qja/full

    May 21, 2013 at 3:48 pm #135896
    Anonymous
    Inactive

    Not sure if you know this but the font doesn’t work. Use fontsquirrel.
    You should also have the previous slider hide when opening a new one. Also it could use some color.

    May 21, 2013 at 5:37 pm #135907
    TheDoc
    Member

    1. You had seven missed closing divs (all of the sidebar stuff)
    2. Your JS was violating a very important rule: DRY (Don’t Repeat Yourself)

    Both of those fixed here: http://jsfiddle.net/mgmdp/2/

    Another note: try to refrain from using `
    `. They shouldn’t be used for separating content, that’s what margins are for!

  • Author
    Posts
Viewing 3 posts - 1 through 3 (of 3 total)
  • The forum ‘CSS’ is closed to new topics and replies.