Grow your CSS skills. Land your dream job.

Class assignment critique?

  • # May 21, 2013 at 3:12 pm

    http://jsfiddle.net/attilahajzer/mgmdp/1/embedded/result/

    check out the code for fonts and all. here’s a screenshot too:

    https://twitpic.com/cs8qja/full

    # May 21, 2013 at 3:48 pm

    Not sure if you know this but the font doesn’t work. Use fontsquirrel.
    You should also have the previous slider hide when opening a new one. Also it could use some color.

    # May 21, 2013 at 5:37 pm

    1. You had seven missed closing divs (all of the sidebar stuff)
    2. Your JS was violating a very important rule: DRY (Don’t Repeat Yourself)

    Both of those fixed here: http://jsfiddle.net/mgmdp/2/

    Another note: try to refrain from using `
    `. They shouldn’t be used for separating content, that’s what margins are for!

    # May 22, 2013 at 1:11 am

    I was aware of the font. I didn’t know about font squirrel. ill read up on it tonight. thank you jarolin. and previously when i did close the divs, they would be seperate. it was a weird quirk i wasn’t able to fix but i guess it has been already thank you. and about the js. i didn’t even know that .sibbling was a possibility. thank you very much!

Viewing 4 posts - 1 through 4 (of 4 total)

You must be logged in to reply to this topic.

*May or may not contain any actual "CSS" or "Tricks".