Forums

astephens

Hi everyone,

Is it improper to give a single class conflicting properties based on the parent element? I know this "works" but I'm wondering if it's considered poor practice.

(I realize in this example you could just remove the li class and define them as "ul.groceries li", but assume the li class is necessary, for instance if we had to define multiple line items)

Thanks!
A.S.



<style>
ul.groceries li.item{ font-size: 1em }
ul.car-parts li.item{ font-size: 2em }
</style>

<ul class=\"groceries\">
  <li class=\"item\">Milk</li>
  <li class=\"item\">Honey</li>
</ul>

<ul class=\"car-parts\">
<li class=\"item\">Muffler</li>
<li class=\"item\">Tire</li>
</ul>

daGUY

That's totally fine. There's no conflict because in the CSS you've defined different parent elements.

Towers

I agree with daGUY on thisâ€”your code looks and is fine (besides the unnecessary li class, of course, but you said you need that).

treehouse : what would you like to learn today?

Forums

Class conflict?