Forums

i3iorn

I've just recently started learning php and its going rather well. I have created a script that goes through the files in a folder and looks for files matching a few conditions. It then creates list items in a menu. It works perfectly for my main navigation. But when I call it to create a secondary menu it returns an empty array instead of the file names as it is supposed to.
Variables and includes


<?php
$page=$_GET['page'];
$path=opendir('/var/www/pages');

include 'script/php/get_files.php';
include "script/php/nav.php";
?>

Here are the two functions that do the heavy lifting

<?php
        function get_files ($path,$prefix,$needle) { 
                $files=array();
                unset($filename);
                while (false !== ($filename = readdir($path)) ) { 
                        if (false !== strpos($filename,$prefix) && false == strpos($filename,".swp")) {
                                $filename = str_replace(".php","",$filename);
                                $filename = str_replace($prefix,"",$filename);
                                if (isset($needle)) {
                                        strstr($filename,$needle);
                                } 
                                array_push($files,$filename);
                        }
                }
                return $files;
        }
?>

<?php
       function nav($path,$prefix,$page) {
                $files = array();
                if(!isset($path) || !isset($prefix)){ echo "Could not load menu"; break;}
                $files = get_files($path,$prefix);
                sort($files);
                foreach ($files as $document) {
                        if( isset($page) ) {
                                if ( $page == $document ) { 
                                        $class="selected";
                                }
                                else {
                                        $class=" ";
                                }
                        }
                        $class = "";
                        $adress=$_SERVER['SERVER_NAME'];
                        echo "<li><a class=\"".$class."\" href=\"http://".$adress."?page=".$document."\">".$document."</a></li>";
                }
        }       
?>

And the part that calls for the nav() function:

        <nav id="site">
                <ul>
                        <?php
                                nav($path,"show.",$page);
                        ?>
                </ul>
        </nav>
        <aside>
                <nav>
                        <ul>
                                <?php 
                                        nav($root,"action."); 
                                ?>
                        </ul>
                </nav>          
        </aside>

i3iorn

The first call to nav() generates three filenames as I expect it to. The second call returns empty though I have double and tripple checked that I have two files that should match.

i3iorn

Feel free to suggest other changes that could be made to reduce the ammount of code or if there are better, safer, ways to write any of this. I know its alot of code but I would be very greatfull.

BenWalker

Do you declare $root anywhere?

i3iorn

Yes sorry forgott to include that.

$root = $path;

It was a part of my attempt to troubleshoot and I forgott to change $root back to $path;

BenWalker

$filename is just a boolean, so unset($filename) doesn't do what you think it does. You need to use closedir() to reset your readdir() function, which means you need to rethink when you use opendir().

BenWalker

<?php
$page=$_GET['page'];
$path='/var/www/pages';

function get_files ($path,$prefix,$needle) { 
	$files=array();
	$handle = opendir($path);
	unset($filename);
	while (false !== ($filename = readdir($handle) ) ) { 
		if (false !== strpos($filename,$prefix) && false == strpos($filename,".swp")) {
			$filename = str_replace(".php","",$filename);
			$filename = str_replace($prefix,"",$filename);
			if (isset($needle)) {
				strstr($filename,$needle);
			} 
			array_push($files,$filename);
		}
	}
	closedir($handle);
	return $files;
}
function nav($path,$prefix,$page) {
	$files = array();
	if(!isset($path) || !isset($prefix)){ echo "Could not load menu"; break;}
	$files = get_files($path,$prefix);
	sort($files);
	foreach ($files as $document) {
		if( isset($page) ) {
			if ( $page == $document ) { 
				$class="selected";
			}
			else {
				$class=" ";
			}
		}
		$class = "";
		$adress=$_SERVER['SERVER_NAME'];
		echo "<li><a class=\"".$class."\" href=\"http://".$adress."?page=".$document."\">".$document."</a></li>";
	}
}       
?>
		<nav id="site">
			<ul>
				<?php
					nav($path,"show.",$page);
				?>
			</ul>
        </nav>
        <aside>
			<nav>
				<ul>
					<?php 
						nav($path,"action."); 
					?>
				</ul>
			</nav>          
        </aside>

i3iorn

Okay, that will put me on the right track. I was thinking about rewriting the entire thing anyway because it started out as 4 line function and I've just put stuff in and try to make it work.

Thank you so much.

mutuelle

mutuelle

treehouse : what would you like to learn today?

Forums

[Solved] Help me understand why this works the first time its called and not the second